Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Primitives] Extract common code of tooltip, popover and hover card #236

Open
pawel-twardziak opened this issue Dec 30, 2024 · 2 comments · May be fixed by #241
Open

[Primitives] Extract common code of tooltip, popover and hover card #236

pawel-twardziak opened this issue Dec 30, 2024 · 2 comments · May be fixed by #241
Assignees
Labels
enhancement New feature or request type: primitives

Comments

@pawel-twardziak
Copy link
Contributor

Feature request

Overview

tooltip, popover and hover card slightly differ, they are 95% of the same code - a huge room for making the code shared.

Examples in other libraries

https://www.spartan.ng/ has this approach applied

Who does this impact? Who is this for?

It impacts DX; it is for developers

Additional context

Reusable and robust code

@pawel-twardziak pawel-twardziak moved this to Todo in v1 Dec 30, 2024
@pawel-twardziak pawel-twardziak moved this from Todo to In progress in v1 Dec 30, 2024
@pawel-twardziak pawel-twardziak self-assigned this Dec 30, 2024
@pawel-twardziak
Copy link
Contributor Author

@radix-ng/core @radix-ng/maintainers my proposal to change the structure is as follows:

obraz

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Dec 30, 2024

@pimenovoleg I've cloned the repo over but the access still does not work for me :(
obraz

UPDATE: everything works fine :) I had to update my token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type: primitives
Projects
Status: In progress
1 participant