Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: racount incremented during unicast, may cause less than intended multicast initial rtr adv #173

Closed
robbat2 opened this issue Feb 20, 2022 · 0 comments · Fixed by #247
Closed

Bug: racount incremented during unicast, may cause less than intended multicast initial rtr adv #173

robbat2 opened this issue Feb 20, 2022 · 0 comments · Fixed by #247
Labels
bug

Comments

@robbat2
Copy link
Member

robbat2 commented Feb 20, 2022

send_ra_forall always increments racount, even if it's doing a unicast response: so if there is a unicast request during the initial period, the counter is incremented, and we might have sent less than the planned number of multicast ads.

Thread where the bug was discovered:
2591d01#commitcomment-67099529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure send_ra_forall racount only increments for non-unicast robbat2/radvd
1 participant
@robbat2