From 48580b8dca92d1ea5f023012d2178a6b2479e385 Mon Sep 17 00:00:00 2001
From: Ben Orchard <thefirstmuffinman@gmail.com>
Date: Thu, 13 Jun 2024 14:51:46 +0100
Subject: [PATCH] Get: improve generic errors

---
 src/Binrep/Get.hs  | 13 +++++++------
 src/Binrep/Test.hs |  1 -
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/Binrep/Get.hs b/src/Binrep/Get.hs
index 9359c3b..d2a156d 100644
--- a/src/Binrep/Get.hs
+++ b/src/Binrep/Get.hs
@@ -94,13 +94,14 @@ getGenericSum
        , Get pt
        , GAssertNotVoid a, GAssertSum a
     ) => ParseCstrTo sumtag pt
-      -> (String -> FP.Parser E pt)
       -> (pt -> pt -> Bool)
       -> Getter a
-getGenericSum parseCstr fIdk ptEq =
-    genericTraverseSum @Get @sumtag parseCstr fIdk fNoMatch ptEq
+getGenericSum parseCstr ptEq =
+    genericTraverseSum @Get @sumtag parseCstr getPt fNoMatch ptEq
   where
       fNoMatch _cd = FP.err EFail -- TODO
+      getPt cd = getWrapGeneric cd $ EGenericSum . EGenericSumTag
+
 
 getGenericSumRaw
     :: forall pt a
@@ -173,9 +174,9 @@ getWrapGeneric' (FP.ParserT f) cd fe =
     FP.ParserT $ \fp eob s st ->
         let os = I# (minusAddr# eob s)
          in case f fp eob s st of
-              FP.Fail# st'   -> FP.Err# st' (E os $ EGeneric cd $ fe EFail)
-              FP.Err#  st' e -> FP.Err# st' (E os $ EGeneric cd $ fe e)
-              x -> x
+              FP.OK#   st' a s -> FP.OK# st' a s
+              FP.Fail# st'     -> FP.Err# st' (E os $ EGeneric cd $ fe EFail)
+              FP.Err#  st' e   -> FP.Err# st' (E os $ EGeneric cd $ fe e)
 
 newtype ViaGetC a = ViaGetC { unViaGetC :: a }
 instance (GetC a, KnownNat (CBLen a)) => Get (ViaGetC a) where
diff --git a/src/Binrep/Test.hs b/src/Binrep/Test.hs
index d20c66d..4e8cd37 100644
--- a/src/Binrep/Test.hs
+++ b/src/Binrep/Test.hs
@@ -50,5 +50,4 @@ instance Put DMagicSum where
 instance Get DMagicSum where
     get = getGenericSum @DMagicSum
         (\p -> fromIntegral @_ @Word8 (natVal' p))
-        (\_cd -> get)
         (==)