Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential case-insensitive import collision: import path should be "github.com/unknwon/com", not "github.com/Unknwon/com" #36

Open
KateGo520 opened this issue Aug 10, 2020 · 3 comments

Comments

@KateGo520
Copy link

Background

The repo github.com/Unknwon/com already renamed to github.com/unknwon/com in the version v1.0.0.
https://github.com/unknwon/com/blob/v1.0.0/example_test.go

package com_test
import (
	"github.com/unknwon/com"
	…
)

The github.com/Unknwon/com is the old path, any repos using it should be updated to import and require github.com/unknwon/com. Or this may take some potential problems.

Solution

Replace all the import paths, change "github.com/Unknwon/com" to "github.com/unknwon/com".
Where did you import it: https://github.com/rai-project/rai/search?q=github.com%2FUnknwon%2Fcom&unscoped_q=github.com%2FUnknwon%2Fcom

@KateGo520
Copy link
Author

@abduld @weiren2 Could you help me review this issue? Thx :p

@aschuh703
Copy link
Contributor

aschuh703 commented Aug 26, 2020 via email

@weiren2
Copy link
Contributor

weiren2 commented Aug 26, 2020

How can I help?
Andy Schuh

@aschuh703 From KateGo520's comment, I think you would need to update the all the import paths of github.com/Unknwon/com to the lower case one github.com/unknwon/com due to the name change. And test the build afterward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants