Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDX lint is broken #90

Closed
bitbeckers opened this issue Feb 13, 2023 · 1 comment · Fixed by #91
Closed

TSDX lint is broken #90

bitbeckers opened this issue Feb 13, 2023 · 1 comment · Fixed by #91

Comments

@bitbeckers
Copy link
Contributor

Creating an issue to fix this in the future if possible.

yarn lint keeps returning

Error: Cannot read config file: /Users/ken/dev/design-system/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: BaseConfig
    at Object.<anonymous> (/Users/ken/dev/design-system/node_modules/eslint-config-prettier/@typescript-eslint.js:1:7)

After some trial-and-error this appears to be and issue with tsdx using an older eslint config:

Ther developer states this it's diffifult to workaround, so configuring eslint in the yarn script is the quickes workaround.

Hotfix in #38

@bitbeckers bitbeckers changed the title TSDX lint TSDX lint is broken Feb 13, 2023
@scottrepreneur scottrepreneur linked a pull request Feb 13, 2023 that will close this issue
@scottrepreneur
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants