Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment_*.json should contain the relevant hash of contracts.json #1309

Open
pirapira opened this issue Oct 23, 2019 · 1 comment
Open

deployment_*.json should contain the relevant hash of contracts.json #1309

pirapira opened this issue Oct 23, 2019 · 1 comment
Labels
efforts: a few days hack P1 urgent, blocker, or makes life easier forever

Comments

@pirapira
Copy link
Contributor

pirapira commented Oct 23, 2019 •
edited
Loading

Then an incident like raiden-network/raiden#5122 can be prevented earlier. TravisCI can compare the hash stored in the deployment files against that stored in contracts.json.

When we upgrade only the service contracts, we do not want to deploy the other contracts. So the stored hash must not be overall_hash but the hashes of the relevant sources.

This means, each entry of contracts.json must contain a hash for each deployment file. Currently, service and raiden.
@pirapira pirapira added P1 urgent, blocker, or makes life easier forever efforts: a few days hack labels Oct 23, 2019
This was referenced Oct 24, 2019
Open
Open
@pirapira
Copy link
Contributor Author

  • Does contracts.json contain one source hash for each bytecode?
  • Does contracts.json contain one hash for raiden and another for services?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few days hack P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirapira