Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not? using the JSONRPC-Client from the Raiden client to interact with the blockchain #342

Closed
2 tasks
christianbrb opened this issue Sep 23, 2019 · 4 comments
Closed
2 tasks
Assignees
Labels
Feature request A request for a new SP feature

Comments

@christianbrb
Copy link
Contributor

Analysis

Current State

Currently, the scenario player is using the JSONRPC-Client from the Raiden client to interact with the blockchain. For all other operations, it is using the Raiden API and CLI.

Problem

The JSONRPC-client is a "private" Raiden client feature.

This leads to several problems

and makes it hard to debug and fix issues.

Solution

  • Analyse which features/tasks are using the JSONRPC-client
  • Decide on next steps
@christianbrb christianbrb added the Feature request A request for a new SP feature label Sep 23, 2019
@deepbrook
Copy link

Generally speaking, any operation that requires sending a transaction, makes use of the JSONRPCClient class.

An issue I see, which is closely related to maintainabilty mentioned above, is that due to tight coupling of the SP with the raiden contracts, changes in those repositories are guaranteed to almost always result in errors/bugs in the SP.

@konradkonrad
Copy link
Contributor

After a conversation with client devs, I believe the proper way is using the raiden client proxies: https://github.com/raiden-network/raiden/tree/develop/raiden/network/proxies

This also relates to #349 -- using the proxies, all transactions will be logged.

@konradkonrad
Copy link
Contributor

See also #315

@palango
Copy link
Contributor

palango commented Mar 9, 2020

Starting with #511 we will use the proxies Raiden uses.

@palango palango closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request A request for a new SP feature
Projects
None yet
Development

No branches or pull requests

4 participants