Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does rails enforce data-method "GET" be uppercase? #507

Closed
nathanallen opened this issue Feb 15, 2018 · 1 comment · May be fixed by #508
Closed

does rails enforce data-method "GET" be uppercase? #507

nathanallen opened this issue Feb 15, 2018 · 1 comment · May be fixed by #508

Comments

@nathanallen
Copy link

At a glance it seems possible that the data-method value could be a lowercase "get", which would fail this check

jquery-ujs/src/rails.js

Line 434 in 4b6e30f

if (metaClick && (!method || method === 'GET') && !data) { return true; }

@jeremy
Copy link
Member

jeremy commented Feb 15, 2018

Confirm, it could. Methods are uppercase, but lowercase usage is common and exhibited elsewhere. data-method is typically omitted entirely for GET requests, which may be why nobody has noticed. PR welcome to add support for lowercase get in this case 😊

@jeremy jeremy closed this as completed Feb 15, 2018
nathanallen added a commit to nathanallen/jquery-ujs that referenced this issue Feb 16, 2018
@nathanallen
ensure data-method value is uppercase before comparison, fixes rails#507
39398ac
@nathanallen nathanallen mentioned this issue Feb 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure data-method value is uppercase before comparison, fixes #507 nathanallen/jquery-ujs
2 participants
@jeremy @nathanallen