Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lighthouse Score #151

Closed
MikeRogers0 opened this issue Feb 25, 2021 · 6 comments
Closed

Improve Lighthouse Score #151

MikeRogers0 opened this issue Feb 25, 2021 · 6 comments

Comments

@MikeRogers0
Copy link
Contributor

MikeRogers0 commented Feb 25, 2021

image
image

I'd love to do some work on improve the current lighthouse scores, mainly around accessibility & performance :)

What is your preferred way for me to chip away at these? I'm thinking I try to create PRs when I can, focusing on the quick wins first then moving onto the harder stuff as I get more confident in the codebase.

@p8
Copy link
Member

p8 commented Feb 25, 2021

@MikeRogers0 Sounds great! Smaller PR's are easier to review/merge.

@MikeRogers0
Copy link
Contributor Author

I'm super excited for https://github.com/zzak/sdoc/pull/154 - I reckon that'll improve the scores massively :D

The next thing I'm going to attempt do is try to compile some of the CSS/JS into single files. I might try to setup a fun netlify preview system as part of that if you'd like? :)

@MikeRogers0
Copy link
Contributor Author

image

Scores have massively improved when I test this against our Netlify preview app. Nice work everyone :)

@p8
Copy link
Member

p8 commented Apr 13, 2021

Maybe we should also add caching to the assets and lazily build the panel tree (only create dom elements when clicking).
https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fedgeapi.rubyonrails.org%2F

@p8
Copy link
Member

p8 commented Apr 13, 2021

Ah, you already created an issue :)
rails/rails-docs-server#25

@MikeRogers0
Copy link
Contributor Author

MikeRogers0 commented Apr 13, 2021

Maybe we should also add caching to the assets

I did make a PR also ( rails/rails-docs-server#24 ), but it didn't get much traction (They'd prefer a asset digest first) :/

Plus their setup appears to be a single server based in the USA. I think they'd be much better off using a CDN (Or Netlify for those sweet PR previews).

Any ideas of how to help the Rails team with their setup @p8 ? (Also is it worth it?)

lazily build the panel tree (only create dom elements when clicking).

This would be really cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants