Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Affiliate Logos Static #166

Open
salimhb opened this issue Jun 10, 2021 · 1 comment
Open

Make Affiliate Logos Static #166

salimhb opened this issue Jun 10, 2021 · 1 comment
Labels
APP: recover app (gastro & live) recover care is whitelabel of the recover app used for all other cases (gastro, sports) rcvr.app Repo: Api The issue needs to be solved in api.rcvr.app REPO: App The issue needs to be solved in rcvr.app

Comments

@salimhb
Copy link
Member

salimhb commented Jun 10, 2021

For #86, the affiliate logos were added to the database and uploaded to S3. This results in a DB-Request, then generating a signed URL for the Logo-File on S3. That's causing unnecessary load for each request to the checkin page.
Solution: remove the logos from the database and hard code them in the frontend code.
@salimhb salimhb added APP: recover app (gastro & live) recover care is whitelabel of the recover app used for all other cases (gastro, sports) rcvr.app Repo: Api The issue needs to be solved in api.rcvr.app REPO: App The issue needs to be solved in rcvr.app labels Jun 10, 2021
@salimhb
Copy link
Member Author

salimhb commented Jul 9, 2021

Note: this also reduces logging and we can downgrade the log storage plan accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
APP: recover app (gastro & live) recover care is whitelabel of the recover app used for all other cases (gastro, sports) rcvr.app Repo: Api The issue needs to be solved in api.rcvr.app REPO: App The issue needs to be solved in rcvr.app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@salimhb