Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Multi-line pasting is broken #1309

Open
drusepth opened this issue Jul 3, 2018 · 5 comments
Open

Multi-line pasting is broken #1309

drusepth opened this issue Jul 3, 2018 · 5 comments

Comments

@drusepth
Copy link

drusepth commented Jul 3, 2018

Steps to reproduce:

  1. Paste the following code into the terminal
echo "Hello"
echo "World"

Observed behavior:

The lines are concatenated together. What gets run is echo "Hello" echo "World".

Expected behavior:

The lines are run in sequence, with the first line run first and then the second line run after the first has completed.

@glyif
Copy link

glyif commented Jul 9, 2018

@drusepth took a look, it looks like both the scanner and the parser are not taking into consideration the new line character.

@le0pard i would say this is a pretty big issue, thoughts?

i can take this bug, will get me more acquainted with upterm's shell. i would think it's using some type of operator-precedence parser for executing commands.

@le0pard
Copy link
Member

le0pard commented Jul 9, 2018

@glyif I am ok, if you want to fix this. Sorry, but don't know, where exactly you need to start.

le0pard added a commit that referenced this issue Aug 31, 2018
Fix for Multi-line pasting is broken #1309
@alex-d-bondarev
Copy link

alex-d-bondarev commented Oct 22, 2018

This issue becomes annoying when you copy/paste long commands, like Docker UP with parameters separated by \ and a new line symbol.
IMHO critical
Reproduced on 0.4.4

@dwkerwin
Copy link

Any update on this? Just tried upterm for the first time, loved it immediately, then tried to copy/paste a multi-line command and was let down to see it not work. Pretty much renders it unusable and seems like it would be an easy enough thing to resolve (says the guy complaining but not offering to fix it).

@le0pard
Copy link
Member

le0pard commented Apr 19, 2019

#1301 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants