Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final start command is run as root #449

Open
1 task done
nebulatgs opened this issue Aug 27, 2022 · 1 comment · May be fixed by #1193
Open
1 task done

Final start command is run as root #449

nebulatgs opened this issue Aug 27, 2022 · 1 comment · May be fixed by #1193
Labels
bug Something isn't working

Comments

@nebulatgs
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The final start command is run as root in the deployed container.
This is bad practice, and can open up vulnerabilities for the app run as root.

This also causes certain programs like puppeteer to refuse to launch (ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported.)

To reproduce

Build a project with Nixpacks.
Run the resulting OCI image.
The start command will be run as root.

Expected behavior

The start command should be deescalated and run as another PID.

Environment

Windows 11, Nixpacks v0.3.8

(affects all versions)

@nebulatgs nebulatgs added the bug Something isn't working label Aug 27, 2022
@Milo123459 Milo123459 assigned Milo123459 and unassigned Milo123459 Aug 27, 2022
@pinkforest
Copy link
Contributor

I wondered about this alongside alpine for some things. I could address this. Just need to dislodge my other PR first of the pipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants