-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RN to v0.74.3, bump outdated packages #5739
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This currently works on prod with latest playstore version
https://linear.app/rainbow/issue/APP-1690/upgrade-rn-to-v0742-qa-bug-cant-unpin-pinned-tokens
Happening on iOS as well per @BrodyHughes
Just pushed a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
* Bump RN to v0.72.14, bump outdated packages * Bump patches, remove outdated patches * lint * Fix old Skia code * Upgrade RN to 0.74.2 * Bump RN to latest, bump Reanimated to v3.13.0 release * Remove codegen from RN patch, re-add squircle patch * Resolve all patch warnings, fix package.json * Fix react-native-video type errors * Upgrade Firebase * Refresh yarn.lock * Fix yarn.lock, delete and ignore all instances of install-state.gz * Fix Moti types * Test CI change * Undo setup-ci change * Rebuild react-native-animated-charts yarn.lock files * Fully rebuild subpackage lock files * Bump packages * Undo graphql yarn.lock changes * small changes * Refresh lock files, dependency fixes * Fix react-native-screen-corner-radius lint errors * Fix lint errors * fix * target CI-9 * Try emptying lock files * Revert "Try emptying lock files" This reverts commit 369116d. * Refresh lock files again * Fully rebuild lock files * Add subpackage lock files * Ignore charts example app * Remove tooltips devDependencies * Update yarn.lock * bump react-native-tooltips * Enable inline yarn logs * tmp env var update * fixes * Test CI changes * run install once * lockfile * Update macstadium-e2e.yml * Revert "Test CI changes" This reverts commit 212ee10. * Revert "Enable inline yarn logs" This reverts commit cdf2fc9. * fix typo * just do yarn install * rename vars tmp * add missing types * Try using sh for CI script * Revert "Try using sh for CI script" This reverts commit 0d18528. * disable linter * disable unit tests * Try all setup-ci steps * Add yarn install * Try cache clean * Rebuild yarn.lock * bundle before pod install * back to yarn setup * yarn setup doesnt work * fix lockfile * Try checksumBehavior: reset * update lockfile * Fix lint * Fix scripts path * fix ts issues * fix commands * fix * fix more types * restore rn tooltips to the right branch * Fix pod install warnings * Possibly fix build errors * Bump detox * Trigger CI * Revert "Trigger CI" This reverts commit aa342cc. * Tighten node version * add version debugging * debug * yarn detox * update rn patch * show node path * more debugging and permissions * rn info * use zshrc * update min ruby version on gemfile * remove xcpretty * add metro transformer * Remove old ratio.me react-native-webview metro exception * Use @react-native/metro-babel-transformer, bump reanimated * Restore query-core patch * Rebuild lock files * Fix ENS resolution in send, remove unused imports * Fix resolveNameOrAddress * Remove old GH root view * Undo Detox version bump * Remove .yarnrc, clean up resolveNameOrAddress return types * Remove Unstoppable send flow test Unstoppable resolution was already broken in develop and was wrongly passing * Fix Hardhat command * Re-enable all CI steps * Update CI cache for Yarn 4 * Revert "Restore query-core patch" This reverts commit 849516a. * Fix local e2e crash due to GH button in RainbowContextWrapper * Use metro-plugin-anisotropic-transform main branch * Update yarn.lock * Enable inline yarn logs * Fix unpinning * Possibly fix duplicate Android installs * Make patch-package work with Yarn 4 * Reapply @tanstack/query-core patch * Updated bitrise.yml with explicit yarn install * Fix bitrise.yml formatting * Fix lint error, add .yarn to .prettierignore * Fix update-token-list script * Fix Bitrise code signing * Fix provisioning profiles * More project.pbxproj fixes * More project.pbxproj edits * Revert "More project.pbxproj edits" This reverts commit 73025d3. * Revert "More project.pbxproj fixes" This reverts commit 6c098a4. * Fix CODE_SIGN_IDENTITY --------- Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: Bruno Barbieri <[email protected]> Co-authored-by: jinchung <[email protected]>
Fixes APP-1666
What changed (plus any additional context for devs)
v0.74.3
Todo:
Screen recordings / screenshots
What to test