Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom gas panel #5902

Merged
merged 4 commits into from
Jun 29, 2024
Merged

fix custom gas panel #5902

merged 4 commits into from
Jun 29, 2024

Conversation

greg-schrammel
Copy link
Contributor

@greg-schrammel greg-schrammel commented Jun 27, 2024

Fixes APP-####

What changed (plus any additional context for devs)

fixes this #5885 (review)

before / after
(notice the estimated fee)

Screen.Recording.2024-06-27.at.18.50.02.mov
Screen.Recording.2024-06-27.at.18.47.45.mov

Screen recordings / screenshots

What to test

@jinchung jinchung self-requested a review June 27, 2024 22:29
@jinchung
Copy link
Member

try with:

  • flashbots off
  • update custom gas and miner tip to below 6 gwei (e.g, 5.6)
  • turn flashbots on
  • go back to custom gas - still shows previously set value of 5.6, until you hit the minus button and then it changes to 6 gwei and prevents the user from going below that again

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 closed this Jun 29, 2024
@brunobar79 brunobar79 reopened this Jun 29, 2024
@jinchung jinchung merged commit d5b5d22 into develop Jun 29, 2024
6 checks passed
@jinchung jinchung deleted the fix-custom-gas branch June 29, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants