Hold to swap button #5920
Merged
Hold to swap button #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
force-pushed
the
gregs/app-1660-add-hold-to-swap-button
branch
from
5774c37
to
2fc0dcd
Compare
greg-schrammel
force-pushed
the
gregs/app-1660-add-hold-to-swap-button
branch
from
2fc0dcd
to
d509cfd
Compare
walmat
reviewed
Jul 17, 2024
walmat
reviewed
Jul 19, 2024
src/__swaps__/screens/Swap/components/GestureHandlerHoldButton.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Matthew Wall <[email protected]>
Also polishes the hold to press interaction
christianbaroni
approved these changes
Jul 27, 2024
BrodyHughes
added a commit
that referenced
this pull request
Aug 1, 2024
…inbow into brody/enable-android-tests * 'brody/enable-android-tests' of github.com:rainbow-me/rainbow: degen mode feature flag (#5969) Fix Android dapp browser gestures (#5964) Add Degen Mode, swap settings panel (#5963) Update flipping logic in SwapInputsController (#5948) Hold to swap button (#5920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1660
Fixes APP-1678
What changed (plus any additional context for devs)
Screen.Recording.2024-07-09.at.14.42.29.mov
Screen recordings / screenshots
What to test