Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a personal profile section. #2

Open
rajat2502 opened this issue Nov 27, 2019 · 32 comments
Open

Add a personal profile section. #2

rajat2502 opened this issue Nov 27, 2019 · 32 comments
Assignees
@dsaharia
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rajat2502
Copy link
Owner

A personalized section where users can see their contribution graphs and other stats will look good in this project.
@rajat2502 rajat2502 added enhancement New feature or request help wanted Extra attention is needed labels Nov 27, 2019
@dsaharia
Copy link

dsaharia commented Dec 1, 2019

I want to work on this issue for KWoC 2019.
For login I have to use Oauth right? then display information regarding stars, followers etc?

@rajat2502
Copy link
Owner Author

@dsaharia don't include login signup for now, just add a profile link to the navbar and in that component add a input box to enter your profile and then use the GitHub's API to show stats.

@rajat2502
Copy link
Owner Author

For reference about what to show in that component you can have a look at https://github.com/rajat2502/GitHub-Finder this app. Keep showing your progress in small steps so that I can approve and you can work further.

@dsaharia
Copy link

dsaharia commented Dec 2, 2019

Yes, Sure. I'll keep you posted by Email?

@rajat2502
Copy link
Owner Author

rajat2502 commented Dec 2, 2019 •
edited
Loading

Sure!!! but you can also join the Gitter channel from the KWoC website.

@rajat2502
Copy link
Owner Author

Are you working?

@dsaharia
Copy link

dsaharia commented Dec 14, 2019 via email

@rajat2502
Copy link
Owner Author

Ok take your time.

@dsaharia
Copy link

dsaharia commented Dec 17, 2019 via email

@rajat2502
Copy link
Owner Author

@dsaharia Yeah that's cool.
For showing, loading add a loader.
Use the same input button as used in the battle component.
Add the profile route to the main navbar

@dsaharia
Copy link

dsaharia commented Dec 17, 2019 via email

@rajat2502
Copy link
Owner Author

Just show me that by hosting.

@dsaharia
Copy link

dsaharia commented Dec 18, 2019 via email

@dsaharia
Copy link

I have some doubts.

  1. The RepoCard component takes data.owner.avatar_url. Why is there owner in between? When I try to use this component for profile section it gives error because there is no owner attribute in the data. What should I do?

@rajat2502
Copy link
Owner Author

Yeah, you can use netlify to host.
Well about the owner thing I am not sure, maybe there are some changes in GitHub's API
If it's working without owner use it that way.

@dsaharia
Copy link

It is working without using the owner. Should I host or send you screenshots of it? Because hosting will take time, and it is already hosted right?

@rajat2502
Copy link
Owner Author

Host your version of website, it's easy try and read about Netlify hosting.

@dsaharia
Copy link

dsaharia commented Dec 20, 2019 •
edited
Loading

I did some changes and added a profile section. It needs UI improvements, working on it. Also hosted it
LINK : https://fervent-lamarr-9bf0e5.netlify.com/
How is it?

@rajat2502
Copy link
Owner Author

Well many UI improvements are needed
image
Also, none of the icons are loading. Please see to it.

@dsaharia
Copy link

It is loading in my pc. I have tested it.
Please see
Screenshot 2019-12-21 at 6 46 37 PM

@rajat2502
Copy link
Owner Author

Not loading!!!

@dsaharia
Copy link

dsaharia commented Dec 21, 2019 •
edited
Loading

It should load. I have tested it in chrome as well as Firefox. Both loading fine.

@Neilblaze
Copy link
Contributor

It should load. I have tested it in chrome as well as Firefox. Both loading fine.

@dsaharia please check issue #11

@dsaharia
Copy link

There might be a issue. But I checked in Safari, Chrome and firefox. All the emoji's were loading fine.

@dsaharia
Copy link

How can I check, any clues?

@rajat2502
Copy link
Owner Author

Okay try to use any emoji service like fontawesome.

@dsaharia
Copy link

Done. Integrated FontAwesome for profile badges.
link: https://fervent-lamarr-9bf0e5.netlify.com
Should I open a PR now?

@rajat2502
Copy link
Owner Author

Well the profile component needs some better design (the design should match with the design of the rest of the page.)
Also, this component should also include some charts and analysis with data. If the work is more I can divide into more than one person.
For now, you can just work on the styling of the component.
Also, if possible try SVG for icons as font-awesome is a heavy library.

@dsaharia
Copy link

Yeah I am currently working on the styling and 1 more person would be good to do the charts and analysis, so that we would discuss it and then do it.

@rajat2502
Copy link
Owner Author

Okay you work on the styling for now.

@dsaharia
Copy link

Link: https://fervent-lamarr-9bf0e5.netlify.com

  1. I have added a CSS file to match the profile section to other parts of the site.
  2. Removed the fontawesome library.
  3. Added SVG icons for the profile section. Working fine now. Also compatible with dark mode.
    Please check.
    Also I need help with the charts and other analysis.

@rajat2502
Copy link
Owner Author

Please decrease the width of the container that contains the total info.

dsaharia added a commit to dsaharia/GitHub-Battle that referenced this issue Jan 2, 2020
@dsaharia
# This is a combination of 3 commits.
82ddd11 
# This is the 1st commit message:

conflicts removed

# This is the commit message rajat2502#2:

profile added to the navbar section

# This is the commit message rajat2502#3:

fontawesome module added
dsaharia added a commit to dsaharia/GitHub-Battle that referenced this issue Jan 2, 2020
@dsaharia
# This is a combination of 5 commits.
4d1d1c9 
# This is the 1st commit message:

conflicts removed

# This is the commit message rajat2502#2:

profile added to the navbar section

# This is the commit message rajat2502#3:

fontawesome module added

# This is the commit message rajat2502#4:

font awesome added for badges

# This is the commit message rajat2502#5:

css files updated for profile section to match other parts of the site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsaharia dsaharia

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsaharia @rajat2502 @Neilblaze