You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Speaking for the grpc gem, when shipping release gems, this -s flag is normally OK because we want to strip symbols anyways.
But it's become apparent that we need to make debug symbols for our pre-compiled binaries available (otherwise, it can be hard to deal with bugs in the wild).
Currently, rake-compiler-dock sets
-s
inLDFLAGS
when installing rubies for cross-compilation (done inrake-compiler-dock/Dockerfile.mri.erb
Line 165 in 9e840c4
I want to say this logic was carried over from rake-compiler/rake-compiler#165.
Speaking for the grpc gem, when shipping release gems, this -s flag is normally OK because we want to strip symbols anyways.
But it's become apparent that we need to make debug symbols for our pre-compiled binaries available (otherwise, it can be hard to deal with bugs in the wild).
I came up with an approach in grpc/grpc#34632, the idea is:
build an unstripped native library
save debug symbols off to the side
strip the native library, and include this in a release gem
publish debug symbols from 2) in a separate auxiliary package
Problem:
Because we have
-s
inLDFLAGS
, in order to do step 1) we need to manually find and remove -s from$LDFLAGS
in ourextconf.rb
.Finding and removing
-s
seems fragile long term. For example, if the flag was renamed to--strip-all
, our logic would break.I'm wondering if we can create more explicit way to prevent automatic stripping on the rake-compiler/rake-compiler-dock side.
The text was updated successfully, but these errors were encountered: