Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version, commit, feature info to binary version output #260

Open
ralexstokes opened this issue May 13, 2024 · 4 comments · May be fixed by #277
Open

Add version, commit, feature info to binary version output #260

ralexstokes opened this issue May 13, 2024 · 4 comments · May be fixed by #277
Labels
good first issue Good for newcomers

Comments

@ralexstokes
Copy link
Owner

No description provided.

@ralexstokes ralexstokes added the good first issue Good for newcomers label Oct 1, 2024
@lean-apple
Copy link

Hello @ralexstokes, I would like to work on this issue to get familiar with the repo.

Can you confirm me the expect result when launching the command cargo run --bin mev -- --version would be for example :

mev Version:  0.3.0
Commit:   0cd0d13
Features: boost, build, relay

or more information are expected ?

@ralexstokes
Copy link
Owner Author

@lean-apple would love a PR here :)

I'd aim to mirror how reth does this: https://github.com/paradigmxyz/reth/blob/2fba3c027b7396db868b162e16635197cd584822/crates/node/core/src/version.rs#L15

so there's a short version with just the repo version and commit

and a long version with more info

it looks like vergen is a popular crate for this

@lean-apple
Copy link

@lean-apple would love a PR here :)

I'd aim to mirror how reth does this: https://github.com/paradigmxyz/reth/blob/2fba3c027b7396db868b162e16635197cd584822/crates/node/core/src/version.rs#L15

so there's a short version with just the repo version and commit

and a long version with more info

it looks like vergen is a popular crate for this

I open a PR, could you assign-me the task ?

@aidenwong812
Copy link

May I try my hand at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants