Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compare numbers with eq, better use eql or = #1

Open
kisp opened this issue Jul 23, 2013 · 3 comments
Open

Do not compare numbers with eq, better use eql or = #1

kisp opened this issue Jul 23, 2013 · 3 comments

Comments

@kisp
Copy link

kisp commented Jul 23, 2013

Hi,

Sorry for making this an issue. I just did not find an easy way to add a comment to the code with my tablet.

Best,
Kilian
@ralt
Copy link
Owner

ralt commented Jul 23, 2013

Why is it better?

@kisp
Copy link
Author

kisp commented Jul 24, 2013

Numbers that are eql are not required to be eq by the standard - they maybe
eq in your implementation, but this is effectively nonportable code.
On Jul 23, 2013 8:54 PM, "Florian Margaine" [email protected]
wrote:

Why is it better?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-21437245
.

@ralt
Copy link
Owner

ralt commented Jul 24, 2013

Oh I didn't know that. Thanks for the information, I'll do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kisp @ralt