Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the throughput monitor from the dataset #39

Open
braceal opened this issue Aug 9, 2022 · 0 comments
Open

Decouple the throughput monitor from the dataset #39

braceal opened this issue Aug 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@braceal
Copy link
Collaborator

braceal commented Aug 9, 2022

We should be able to set this using trainer max_steps. That would fully decouple it from the specific dataset. Currently, this code depends on the Dataset class implementing small_subset.

# Select size of subset to use, more ranks require more data to compute stats.
nodes_to_sample_size = {1: 1600, 2: 1600, 4: 3200, 8: 6400}
new_config.small_subset = nodes_to_sample_size.get(cfg.num_nodes, 16000)
@braceal braceal added the enhancement New feature or request label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant