Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist: add cargo metadata for cargo-binstall #653

Merged
merged 4 commits into from
Oct 17, 2023
Merged

dist: add cargo metadata for cargo-binstall #653

merged 4 commits into from
Oct 17, 2023

Conversation

rami3l
Copy link
Owner

@rami3l rami3l commented Oct 17, 2023

Closes #652.

@rami3l rami3l mentioned this pull request Oct 17, 2023
Closed
@rami3l rami3l force-pushed the dist/cargo-binstall branch 6 times, most recently from 3e11763 to 726e1c0 Compare October 17, 2023 02:31
@rami3l rami3l force-pushed the dist/cargo-binstall branch from 726e1c0 to 3a6adeb Compare October 17, 2023 02:58
@rami3l
Copy link
Owner Author

rami3l commented Oct 17, 2023 •
edited
Loading

Although I'd like to see this introduced, Windows installation won't work, and I don't currently wish to work around it (zips are here for the Windows builds for a reason).

Blocked on cargo-bins/cargo-binstall#1080 (and Majored/rs-async-zip#94 in the upstream).

@rami3l
Copy link
Owner Author

rami3l commented Oct 17, 2023 •
edited
Loading

@bb010g I'm merging this PR as-is 1, opening a new issue specifically to track these Windows-related upstream issues. With a future cargo-binstall version that comes with a fix (or a workaround), there should be no further changes required from our side.

Footnotes

  1. ... except temporarily disabling the test for Windows, as you might use choco or scoop for this if you're on Windows, and I guess it's probably the Linux users that need cargo-binstall the most. ↩

@rami3l rami3l force-pushed the dist/cargo-binstall branch from 2140b10 to 02146b7 Compare October 17, 2023 04:24
@rami3l rami3l merged commit 02146b7 into master Oct 17, 2023
@rami3l rami3l deleted the dist/cargo-binstall branch October 17, 2023 04:38
@rami3l rami3l mentioned this pull request Oct 17, 2023
Closed
@rami3l rami3l temporarily deployed to github-pages October 17, 2023 04:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support cargo binstall for release artifacts
1 participant
@rami3l