From 5b919d89797fffd1c826ed08085efa908507991b Mon Sep 17 00:00:00 2001 From: Stanislav Gelman Date: Mon, 16 Sep 2019 10:26:47 +0300 Subject: [PATCH 1/3] =?UTF-8?q?=E2=9C=8F=EF=B8=8F=20change=20to=20feulPerc?= =?UTF-8?q?ent=20due-to=20official=20typo?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pubg_python/domain/telemetry/objects.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pubg_python/domain/telemetry/objects.py b/pubg_python/domain/telemetry/objects.py index cd6ffd0..da51b88 100644 --- a/pubg_python/domain/telemetry/objects.py +++ b/pubg_python/domain/telemetry/objects.py @@ -100,7 +100,7 @@ def from_dict(self): self.vehicle_type = self._data.get('vehicleType') self.vehicle_id = self._data.get('vehicleId') self.health_percent = self._data.get('healthPercent') - self.fuel_percent = self._data.get('fuelPercent') + self.fuel_percent = self._data.get('feulPercent') def __str__(self): return self.name From 78cb9a986ab6824e86519e70d9e1614504a9f7af Mon Sep 17 00:00:00 2001 From: Stanislav Gelman Date: Mon, 16 Sep 2019 10:27:42 +0300 Subject: [PATCH 2/3] =?UTF-8?q?=E2=9C=85=20add=20vehicle=20fuel=5Fpercent?= =?UTF-8?q?=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tests/test_telemetry_events.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/test_telemetry_events.py b/tests/test_telemetry_events.py index b2477b9..e3cf2d5 100644 --- a/tests/test_telemetry_events.py +++ b/tests/test_telemetry_events.py @@ -268,10 +268,14 @@ def test_log_vault_start(): def test_log_vehicle_ride(): events = telemetry.events_from_type('LogVehicleRide') - data = events[223] + data = events[256] assert isinstance(data, LogVehicleRide) assert isinstance(data.character, Character) assert isinstance(data.vehicle, Vehicle) + if data.vehicle.health_percent != 100: + assert isinstance(data.vehicle.health_percent, float) + assert isinstance(data.vehicle.fuel_percent, float) + assert isinstance(data.vehicle, Vehicle) assert isinstance(data.fellow_passengers[0], Character) assert isinstance(data.seat_index, int) assert str(data.vehicle) in VEHICLE_MAP_VALUES From 9f738dd9b932484158b2fd4d6be2e1ad4b4cb27f Mon Sep 17 00:00:00 2001 From: Stanislav Gelman Date: Mon, 16 Sep 2019 15:02:12 +0300 Subject: [PATCH 3/3] :pencil: add todo --- pubg_python/domain/telemetry/objects.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pubg_python/domain/telemetry/objects.py b/pubg_python/domain/telemetry/objects.py index da51b88..eb94ff2 100644 --- a/pubg_python/domain/telemetry/objects.py +++ b/pubg_python/domain/telemetry/objects.py @@ -100,6 +100,7 @@ def from_dict(self): self.vehicle_type = self._data.get('vehicleType') self.vehicle_id = self._data.get('vehicleId') self.health_percent = self._data.get('healthPercent') + # TODO: update feulPercent when fixed in API self.fuel_percent = self._data.get('feulPercent') def __str__(self):