diff --git a/pkg/rancher-desktop/assets/scripts/spin-operator.namespace.yaml b/pkg/rancher-desktop/assets/scripts/spin-operator.namespace.yaml deleted file mode 100644 index 4ee441a75d9..00000000000 --- a/pkg/rancher-desktop/assets/scripts/spin-operator.namespace.yaml +++ /dev/null @@ -1,4 +0,0 @@ -apiVersion: v1 -kind: Namespace -metadata: - name: spin-operator diff --git a/pkg/rancher-desktop/assets/scripts/spin-operator.shim-executor.yaml b/pkg/rancher-desktop/assets/scripts/spin-operator.shim-executor.yaml deleted file mode 100644 index 357046c1f55..00000000000 --- a/pkg/rancher-desktop/assets/scripts/spin-operator.shim-executor.yaml +++ /dev/null @@ -1,8 +0,0 @@ -apiVersion: core.spinoperator.dev/v1alpha1 -kind: SpinAppExecutor -metadata: - name: containerd-shim-spin -spec: - createDeployment: true - deploymentConfig: - runtimeClassName: spin diff --git a/pkg/rancher-desktop/assets/scripts/spin-operator.helm-chart.yaml b/pkg/rancher-desktop/assets/scripts/spin-operator.yaml similarity index 52% rename from pkg/rancher-desktop/assets/scripts/spin-operator.helm-chart.yaml rename to pkg/rancher-desktop/assets/scripts/spin-operator.yaml index 3f6cc096d2f..9a716915802 100644 --- a/pkg/rancher-desktop/assets/scripts/spin-operator.helm-chart.yaml +++ b/pkg/rancher-desktop/assets/scripts/spin-operator.yaml @@ -1,3 +1,18 @@ +--- +apiVersion: core.spinoperator.dev/v1alpha1 +kind: SpinAppExecutor +metadata: + name: containerd-shim-spin +spec: + createDeployment: true + deploymentConfig: + runtimeClassName: spin +--- +apiVersion: v1 +kind: Namespace +metadata: + name: spin-operator +--- apiVersion: helm.cattle.io/v1 kind: HelmChart metadata: @@ -7,5 +22,5 @@ spec: chart: "https://%{KUBERNETES_API}%/static/rancher-desktop/spin-operator.tgz" targetNamespace: spin-operator # Old versions of the helm-controller don't support createNamespace, so we - # create the namespace separately via spin-operator.namespace.yaml. + # created the namespace ourselves. createNamespace: false diff --git a/pkg/rancher-desktop/backend/backendHelper.ts b/pkg/rancher-desktop/backend/backendHelper.ts index 2f56ebd73fe..4570ced9315 100644 --- a/pkg/rancher-desktop/backend/backendHelper.ts +++ b/pkg/rancher-desktop/backend/backendHelper.ts @@ -7,9 +7,7 @@ import yaml from 'yaml'; import INSTALL_CONTAINERD_SHIMS_SCRIPT from '@pkg/assets/scripts/install-containerd-shims'; import CONTAINERD_CONFIG from '@pkg/assets/scripts/k3s-containerd-config.toml'; -import SPIN_OPERATOR_HELM_CHART from '@pkg/assets/scripts/spin-operator.helm-chart.yaml'; -import SPIN_OPERATOR_NAMESPACE from '@pkg/assets/scripts/spin-operator.namespace.yaml'; -import SPIN_OPERATOR_SHIM_EXECUTOR from '@pkg/assets/scripts/spin-operator.shim-executor.yaml'; +import SPIN_OPERATOR from '@pkg/assets/scripts/spin-operator.yaml'; import { BackendSettings, VMExecutor } from '@pkg/backend/backend'; import { LockedFieldError } from '@pkg/config/commandLineOptions'; import { ContainerEngine, Settings } from '@pkg/config/settings'; @@ -29,9 +27,7 @@ const MANIFEST_DIR = '/var/lib/rancher/k3s/server/manifests'; const MANIFEST_RUNTIMES_YAML = `${ MANIFEST_DIR }/z100-runtimes.yaml`; const MANIFEST_CERT_MANAGER = `${ MANIFEST_DIR }/z110-cert-manager.yaml`; const MANIFEST_SPIN_OPERATOR_CRDS = `${ MANIFEST_DIR }/z120-spin-operator.crds.yaml`; -const MANIFEST_SPIN_OPERATOR_SHIM_EXECUTOR = `${ MANIFEST_DIR }/z121-spin-operator.shim-executor.yaml`; -const MANIFEST_SPIN_OPERATOR_NAMESPACE = `${ MANIFEST_DIR }/z122-spin-operator.namespace.yaml`; -const MANIFEST_SPIN_OPERATOR_CHART = `${ MANIFEST_DIR }/z123-spin-operator.chart.yaml`; +const MANIFEST_SPIN_OPERATOR = `${ MANIFEST_DIR }/z125-spin-operator.yaml`; const STATIC_DIR = '/var/lib/rancher/k3s/server/static/rancher-desktop'; const STATIC_SPIN_OPERATOR_CHART = `${ STATIC_DIR }/spin-operator.tgz`; @@ -301,9 +297,7 @@ export default class BackendHelper { vmx.copyFileIn(path.join(paths.resources, 'cert-manager.yaml'), MANIFEST_CERT_MANAGER), vmx.copyFileIn(path.join(paths.resources, 'spin-operator.crds.yaml'), MANIFEST_SPIN_OPERATOR_CRDS), vmx.copyFileIn(path.join(paths.resources, 'spin-operator.tgz'), STATIC_SPIN_OPERATOR_CHART), - vmx.writeFile(MANIFEST_SPIN_OPERATOR_SHIM_EXECUTOR, SPIN_OPERATOR_SHIM_EXECUTOR, 0o644), - vmx.writeFile(MANIFEST_SPIN_OPERATOR_NAMESPACE, SPIN_OPERATOR_NAMESPACE, 0o644), - vmx.writeFile(MANIFEST_SPIN_OPERATOR_CHART, SPIN_OPERATOR_HELM_CHART, 0o644), + vmx.writeFile(MANIFEST_SPIN_OPERATOR, SPIN_OPERATOR, 0o644), ]); } diff --git a/pkg/rancher-desktop/main/commandServer/settingsValidator.ts b/pkg/rancher-desktop/main/commandServer/settingsValidator.ts index 6f50672569c..fa8263660f1 100644 --- a/pkg/rancher-desktop/main/commandServer/settingsValidator.ts +++ b/pkg/rancher-desktop/main/commandServer/settingsValidator.ts @@ -381,7 +381,7 @@ export default class SettingsValidator { return false; } - if (mergedSettings.kubernetes.version === '' || semver.gt('1.22.0', mergedSettings.kubernetes.version) ) { + if (mergedSettings.kubernetes.version === '' || semver.gt('1.22.0', mergedSettings.kubernetes.version)) { errors.push(`Setting ${ fqname } requires Kubernetes 1.22 or later`); this.isFatal = true;