From b993d88932204b2a2a9430ccdda47992150724b1 Mon Sep 17 00:00:00 2001
From: Richard Cox <richard.cox@suse.com>
Date: Tue, 23 Jul 2024 13:57:22 +0100
Subject: [PATCH] Fix nagivation from Global Settings --> Performance to any
 Cluster Explorer custom list - 2.8 based bug - Only reproducible when   -
 performance settings have been changed   - navigating from performance page
 to list page - Root effect   - Contstant trigger of two computed properties  
    - namespaceFilterRequired        -
 shell/mixins/resource-fetch-namespaced.js      - namespaceFilter -->
 __namespaceRequired --> value (all same colour, suggesting our code)        -
 tracing shows this also to start from
 shell/mixins/resource-fetch-namespaced.js

---
 shell/pages/c/_cluster/settings/performance.vue | 2 +-
 shell/utils/settings.ts                         | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/shell/pages/c/_cluster/settings/performance.vue b/shell/pages/c/_cluster/settings/performance.vue
index 27a7e83d9a1..ffeee8cf99f 100644
--- a/shell/pages/c/_cluster/settings/performance.vue
+++ b/shell/pages/c/_cluster/settings/performance.vue
@@ -61,7 +61,7 @@ export default {
 
   data() {
     return {
-      uiPerfSetting:              DEFAULT_PERF_SETTING,
+      uiPerfSetting:              null,
       authUserTTL:                null,
       bannerVal:                  {},
       value:                      {},
diff --git a/shell/utils/settings.ts b/shell/utils/settings.ts
index 9174ba1b33d..1af7553a724 100644
--- a/shell/utils/settings.ts
+++ b/shell/utils/settings.ts
@@ -102,5 +102,7 @@ export const getPerformanceSetting = (rootGetters: Record<string, (arg0: string,
   }
 
   // Start with the default and overwrite the values from the setting - ensures we have defaults for newly added options
-  return Object.assign(DEFAULT_PERF_SETTING, perfSetting || {});
+  const safeDefaults = Object.assign({}, DEFAULT_PERF_SETTING);
+
+  return Object.assign(safeDefaults, perfSetting || {});
 };