Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded docker install URLs from component #10849

Open
rak-phillip opened this issue Apr 19, 2024 · 0 comments
Open

Remove hard-coded docker install URLs from component #10849

rak-phillip opened this issue Apr 19, 2024 · 0 comments
Labels
ember Ember UI Issue kind/tech-debt Technical debt QA/None
Milestone

Comments

@rak-phillip
Copy link
Member

We currently hard-code the list of docker install URLs in the out variable of the form-engine-opts component1. This list acts as a cache so that previous versions of docker remain available to users after a new one is published.

This requires us to manually update the code every time a new version of docker is released and can result in presenting out of date information to users.

Proposed Solution

Remove the hard-coded list of URLs and generate the list based on the available docker versions.

Additional Information

Footnotes

  1. https://github.com/rancher/ui/blob/a9ca59cec314b2dd554a0fc1d64a354cac9408a6/lib/shared/addon/components/form-engine-opts/component.js#L49-L90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ember Ember UI Issue kind/tech-debt Technical debt QA/None
Projects
None yet
Development

No branches or pull requests

4 participants