Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts carousel icons in dark mode are stretched #11845

Closed
richard-cox opened this issue Sep 6, 2024 · 1 comment · Fixed by #11782
Closed

Charts carousel icons in dark mode are stretched #11845

richard-cox opened this issue Sep 6, 2024 · 1 comment · Fixed by #11782
Assignees
@richard-cox
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Milestone
v2.10.0

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: v2.8(?)

Describe the bug

  • the carousel shows icons for entries
  • the icons are placed in a container which a white background
  • the container is stretched to the bottom of the card area
  • this leads to visually unappealing icons

To Reproduce

  • change UI to dark mode
  • cluster explorer --> Apps --> Charts

Result
image

Expected Result
image
@richard-cox richard-cox added this to the v2.10.0 milestone Sep 6, 2024
@richard-cox richard-cox self-assigned this Sep 6, 2024
@richard-cox richard-cox added the QA/manual-test Indicates issue requires manually testing label Sep 6, 2024
@github-actions github-actions bot added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed QA/manual-test Indicates issue requires manually testing labels Sep 6, 2024
@richard-cox richard-cox mentioned this issue Sep 6, 2024
Merged
7 tasks
@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Sep 6, 2024
@richard-cox richard-cox changed the title Charts carousel icons in white mode are stretched Charts carousel icons in dark mode are stretched Sep 16, 2024
@izaac
Copy link
Contributor

izaac commented Oct 18, 2024

Validated on Rancher version: v2.10-5d66d49d7a72b4c439a33043007e9bb0223c8693-head
UI: master cf8c6d1

This is no longer reproducible on this Rancher/UI version. Icons look as expected.

@izaac izaac closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-cox richard-cox

Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Improve visuals of small carousel logos in dark mode richard-cox/dashboard
2 participants
@izaac @richard-cox