Add disabled prop to ColorInput.vue
#12283
Open
+40
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a disabled prop to
ColorInput.vue
so that we can better control how the disabled state and styles are applied.Fixes #12274
Occurred changes and/or fixed issues
ColorInput.vue
isDisabled
computed prop to determine ifdisabled
styles and state should be appliedTechnical notes summary
The original regression looks related to how fallthrough attributes are applied to components in Vue3. I thought it best to explicitly define a
disabled
prop so that we can more easily control disabled states in this component.Areas or cases that should be tested
Anywhere that the color picker is used, see issue for more details.
Areas which could experience regressions
Anywhere that the color picker is used.
Checklist