Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disabled prop to ColorInput.vue #12283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 17, 2024

Summary

This adds a disabled prop to ColorInput.vue so that we can better control how the disabled state and styles are applied.

Fixes #12274

Occurred changes and/or fixed issues

  • Add disabled prop to ColorInput.vue
  • Add isDisabled computed prop to determine if disabled styles and state should be applied

Technical notes summary

The original regression looks related to how fallthrough attributes are applied to components in Vue3. I thought it best to explicitly define a disabled prop so that we can more easily control disabled states in this component.

Areas or cases that should be tested

Anywhere that the color picker is used, see issue for more details.

Areas which could experience regressions

Anywhere that the color picker is used.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.10.0 milestone Oct 17, 2024
@rak-phillip rak-phillip self-assigned this Oct 17, 2024
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast 🚤

Good idea about the prop.

LGTM

@rak-phillip
Copy link
Member Author

Failing test passes locally, but fails in CI. Attempting to understand what the difference is between the environments that could contribute to the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Cluster Badge modal validation error
2 participants