Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster provisioning logs entries not logged on UI #168

Open
cpinjani opened this issue May 29, 2023 · 7 comments
Open

Cluster provisioning logs entries not logged on UI #168

cpinjani opened this issue May 29, 2023 · 7 comments
Assignees
Labels
kind/bug Something isn't working kind/usability
Milestone

Comments

@cpinjani
Copy link
Contributor

cpinjani commented May 29, 2023

Rancher Server Setup
Rancher version: 2.7-head - fbca7c3
Installation option: Helm Chart
If Helm Chart, Kubernetes Cluster and version: EKS 1.25

Information about the Cluster
Kubernetes version: EKS with Kubernetes 1.25
Cluster Type (Downstream): Hosted = EKS

User Information
What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) - Admin

Describe the bug
Cluster provisioning logs entries not logged on UI
Issue exists for other Hosted providers also.

To Reproduce
Add valid AWS cloud credentials
Provision downstream EKS cluster
Check Cluster > Provisioning Log tab

Result
User unable to check provisioning logs

Screenshots
image

@kkaempf kkaempf added the kind/bug Something isn't working label Aug 15, 2023
@furkatgofurov7 furkatgofurov7 self-assigned this Nov 28, 2023
@furkatgofurov7
Copy link
Contributor

I started looking into this one and so far here are my initial findings:

  1. I can repro it and provisioning logs are not visible in GKE at least and should probably be the case in other hosted providers (AKS/EKS)
  2. Provisioning logs used to be added to the last line of cluster object and UI read it from there in the past, but there was a backend change so now logs should be written to the configMap and UI has to read the logs from cm. UI part looks to be adapted to that backend change in Cluster provisioning log dashboard#4605, however, there is a chance it needs more changes in case of hosted providers
  3. Other assumption would be the Rancher core itself, where we need to enable or expose those logs from when provisioning Hosted providers

@mjura mjura self-assigned this Nov 30, 2023
@mjura
Copy link
Contributor

mjura commented Dec 5, 2023

Provisioning logs in Rancher are generated by "github.com/rancher/rancher/pkg/clusterprovisioninglogger"
https://github.com/rancher/rancher/blob/release/v2.8/pkg/controllers/management/clusterprovisioner/driver.go#L22
but it is skipped for Hosted Providers KEv2
https://github.com/rancher/rancher/blob/release/v2.8/pkg/controllers/management/clusterprovisioner/provisioner.go#L115

@mattfarina Question is if this should fixed on Rancher site or we should add logging service to Hosted Providers ?

@mjura
Copy link
Contributor

mjura commented Dec 5, 2023

This problem has to be discussed with Rancher Team

@kkaempf kkaempf added this to the 2024-Q2-v2.8x milestone Dec 8, 2023
@mattfarina
Copy link

@mjura I think you're going to need to add the logging to the hosted providers. The code you link to is the provisioner. It essentially says to skip provisioning handling for those cases. In those cases the hosted provider controllers would do the work. They will need to supply the logs, if I understand it correctly.

@jakefhyde Does this look right?

@jakefhyde
Copy link
Contributor

@mjura I think you're going to need to add the logging to the hosted providers. The code you link to is the provisioner. It essentially says to skip provisioning handling for those cases. In those cases the hosted provider controllers would do the work. They will need to supply the logs, if I understand it correctly.

@jakefhyde Does this look right?

Yes, this looks correct, it will be the responsibility of the hosted provider controllers to populate the provisioning-log configmap.

@mjura mjura modified the milestones: v2.8-Next2, v2.9.0 Jul 2, 2024
@kkaempf kkaempf modified the milestones: v2.9.0, v2.9-Next1 Jul 2, 2024
@kkaempf kkaempf modified the milestones: v2.9-Next1, v2.9-Next2 Aug 6, 2024
@kkaempf kkaempf modified the milestones: v2.9.3, v2.10.0 Oct 1, 2024
@gaktive
Copy link
Member

gaktive commented Oct 22, 2024

@salasberryfin & @yiannistri to review this ticket and figure out what to do next. Azure is the 1st place to look but this appears to be the case across multiple platforms.

@mjura
Copy link
Contributor

mjura commented Oct 24, 2024

@salasberryfin & @yiannistri to review this ticket and figure out what to do next. Azure is the 1st place to look but this appears
to be the case across multiple platforms.

In my opinion it is design decision related to what we have currently with
rancher/aks-operator#179 (comment)

@kkaempf kkaempf modified the milestones: v2.10.0, v2.10.1 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/usability
Development

No branches or pull requests

7 participants