correctDrift.enabled: false in fleet.yaml has no effect

[jhoblitt]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

---
defaultNamespace: rook-ceph
labels:
  bundle: &name rook-ceph-conf
helm:
  releaseName: *name
  atomic: false
  takeOwnership: true
  timeoutSeconds: 3600
correctDrift:
  enabled: false
dependsOn:
  - selector:
      matchLabels:
        bundle: rook-ceph-cluster

Results in

kind: Bundle
metadata:
  creationTimestamp: "2024-02-16T15:46:21Z"
  generation: 4
  labels:
    bundle: rook-ceph-conf
    fleet.cattle.io/commit: 0b0dcfb9ff35d561e2ae52356f9aeddb2d636864
    fleet.cattle.io/repo-name: kueyen
  name: kueyen-fleet-lib-rook-ceph-conf
  namespace: fleet-default
  resourceVersion: "120977600"
  uid: d6fb879b-88e9-4a06-914f-bf9571bb5947
spec:
  correctDrift:
    enabled: true
  defaultNamespace: rook-ceph
  dependsOn:
  - selector:
      matchLabels:
        bundle: rook-ceph-cluster

When correctDrift.enabled: true is set on the associated GitRepo resource.

Expected Behavior

I would expect that it is possible to set all BundleDeploymentOptions from a fleet.yaml file and that these options would override values set in the GitRepo resource.

Steps To Reproduce

1. Create a GitRepo resource with correctDrift.enabled: true.
2. Create a fleet.yaml with correctDrift.enabled: false
3. Inspect the generated bundle

Environment

- Architecture: amd64
- Fleet Version: 0.9.0
- Cluster:
  - Provider: rke1
  - Options:
  - Kubernetes Version: 1.25.9

Logs

No response

Anything else?

Possibility related to #1794 and #2001?

[jhoblitt]

I'm wondering if this might already be fixed in 0.9.1 via #1982. Rancher 2.8.3 was tagged a few days ago and bundles fleet 0.9.2, so I hope to test this soon.

[manno]

Is this bug fixed by Fleet >0.9.0?

[jhoblitt]

I will try to retest today.

[jhoblitt]

This still isn't working in 0.9.8 and 0.10.1.

[jhoblitt]

This is still present in 0.10.3.