You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using fleet to deploy the following fleet charts, workload resources are annotated with helm/resource-policy: keep, but we could not figure out why. By searching the source code of their helm charts, we can only see the crds are annotated with such setting.
defaultNamespace: argohelm:
# Use a custom location for the Helm chart. This can refer to any go-getter URL.# This allows one to download charts from most any location. Also know that# go-getter URL supports adding a digest to validate the download. If repo# is set below this field is the name of the chart to lookupchart: argo-workflowsrepo: https://argoproj.github.io/argo-helmversion: 0.41.14releaseName: argo-workflowsvalues:
fullnameOverride: argo-workflowsserver:
extraArgs: [--auth-mode=server]images:
pullPolicy: IfNotPresentcrds:
keep: false # avoid argo conflicts between different gitrepo due to ownership annotation
The resulted deployments are annotated with helm.sh/resource-policy set to keep
Backport of #2716
Is there an existing issue for this?
Current Behavior
When using fleet to deploy the following fleet charts, workload resources are annotated with
helm/resource-policy: keep
, but we could not figure out why. By searching the source code of their helm charts, we can only see the crds are annotated with such setting.Using
argo-workflows:0.41.14
as an example, the only resources annotated withhelm.sh/resource-policy: keep
are those under/templates/crds
: https://github.com/search?q=repo%3Aargoproj%2Fargo-helm+path%3A%2Fcharts%2Fargo-workflows%2F**+%22resource-policy%22&type=codeBut when installing via fleet config:
The resulted deployments are annotated with
helm.sh/resource-policy
set tokeep
Expected Behavior
The workloads are not annotated with
helm.sh/resource-policy: keep
unless it is defined in helm charts.Steps To Reproduce
The sample fleet yaml config can be located at https://github.com/aDisplayName/bugsamplecode/tree/main/20240808
Environment
Logs
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: