Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Using custom VM images is currently impossible #104

Open
trenton42 opened this issue Jun 15, 2018 · 0 comments
Open

Using custom VM images is currently impossible #104

trenton42 opened this issue Jun 15, 2018 · 0 comments

Comments

@trenton42
Copy link

trenton42 commented Jun 15, 2018

The VM controller always prefixes images with vm.Spec.MachineImage (defined as the constant rancher/vm-%s). This prevents the use of custom machine images.

https://github.com/rancher/vm/blob/62fde3566e8ed2822d514dc9bc9c9a184f249608/pkg/common/constants.go#L11

https://github.com/rancher/vm/blob/f0b2f2cd700f7273ea9f6ccb10ca4f05a4130779/pkg/controller/vm/util.go#L71

Also, the UI has the sample images hard-coded, and depends on the convention above

https://github.com/LLParse/longhorn-ui/blob/748012e17124d95a41efb290ddfb111550b55d1b/src/routes/instances/CreateInstance.js#L98-L106

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant