Remove use of JsZip #5167
Merged
Remove use of JsZip #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
requested changes
Sep 5, 2024
| @@ -10,21 +9,6 @@ export function downloadFile(fileName, content, contentType = 'text/plain;charse | |||
| saveAs(blob, fileName); | |||
| } | |||
|
|
|||
| // [{name: 'file1', file: 'data'}, {name: 'file2', file: 'data2'}] | |||
| export function generateZip(files) { | |||
There was a problem hiding this comment.
This function is still being called in downloadResourceYaml. It should throw an error when a user attempts to bulk-download yamls but instead the request to fetch the yamls for download fail with a 500 error.
|
Removed downloadYaml, as the backend API does not work and this is legacy UI |
mantis-toboggan-md
previously approved these changes
Sep 9, 2024
|
@mantis-toboggan-md Updated following merge of dependabot PR |
mantis-toboggan-md
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the JsZip library.
This was only being used in 2 parts of the codebase - cis scans and pipelines - both of these are no longer shown in the UI.
For simplicity, the code has been removed and errors are logged - these code paths should not be reachable in the UI - we will prune this code in the future as part of a larger tidy-up effort.