Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processPrefix should be configurable #11

Open
jayunit100 opened this issue Nov 19, 2020 · 1 comment
Open

processPrefix should be configurable #11

jayunit100 opened this issue Nov 19, 2020 · 1 comment

Comments

@jayunit100
Copy link

We may not want to expose "rancher-wins" names on a host in all cases, and in some cases, we may want to disable this renaming of the process (for example, if you want to hack a patch into a file, you might want rancher to just run the file as-is). Also there might be security or other reasons why you dont want to expose that as a process name.

Would it break anyhing to change https://github.com/rancher/wins/blob/master/pkg/apis/process_service.go#L20 to , say, a cmd line option or environment variable ?

@aiyengar2
Copy link
Contributor

To my knowledge, there are two things to consider with changing the renaming process for the host processes:

  1. Currently, wins fully solves the problem of getting a binary onto the host but does not handle all cases of removing a binary from the host. For example, if the wins server is restarted or stopped, all the processes that were added onto the host on behalf of clients may potentially remain stuck on the host if they aren't re-registered in the process pool that the wins server tracks (e.g. if the wins client that requested it died while the wins server was down). As a result, keeping a common prefix is a way for a Windows admin to be able to manually identify and kill such orphaned processes.
  2. Even if we provided a way to modify the processPrefix, this would have to be a command line argument for the wins server, not for each wins client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants