Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually make use of redux-offline and use it to make _all_ our requests #163

Open
randytarampi opened this issue Oct 26, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers requirements gathering scoping Issues that need details hashed out
Milestone

Comments

@randytarampi
Copy link
Owner

Use some combination of https://github.com/redux-offline/redux-offline#3-decorate-actions-with-offline-metadata and https://github.com/redux-offline/redux-offline/blob/develop/docs/recipes/customize-requests.md#the-effect-reconciler to rejig the way we currently fetchPosts, fetchResume and fetchLetter.

The trouble here is that we're currently dispatching thunks 'cause there some response handling work that we need to do that really isn't appropriate to put in the reducer (at least, that's my feeling), like casting the response to our desired Immutable Record type.

Exactly how we go about doing this isn't clear – but I'm thinking that we rejig the reconciler to take a reference to some function that runs after the response is received and transforms it into something worth dispatching in the commit or rollback action.

We basically want to use this, or something similar.

@randytarampi randytarampi added enhancement New feature or request good first issue Good for newcomers requirements gathering labels Oct 26, 2018
@randytarampi randytarampi added the scoping Issues that need details hashed out label Nov 20, 2018
@randytarampi randytarampi added this to the It's an app! milestone Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers requirements gathering scoping Issues that need details hashed out
Projects
None yet
Development

No branches or pull requests

1 participant