Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup lockfiles and/or shrinkwraps #175

Closed
randytarampi opened this issue Oct 28, 2018 · 0 comments
Closed

Setup lockfiles and/or shrinkwraps #175

randytarampi opened this issue Oct 28, 2018 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@randytarampi
Copy link
Owner

Ugh. Gross. I was hoping to be able to get away with this for a little bit longer, but having the cached version of immutable get blown away in the middle of a release and have #174 popup was pretty disconcerting.

We'll want to bring in greenkeeper-lockfile or something.
@randytarampi randytarampi added enhancement New feature or request help wanted Extra attention is needed backlog Issues not queued for work any time soon labels Oct 28, 2018
randytarampi added a commit that referenced this issue Oct 29, 2018
@randytarampi
chore: Commit package-lock.json.
d0b4154 
`greenkeeper` has native support for projects with lockfiles as long as all their packages are publically available, so this should suffice to address my greater concerns in #175.

Would still be nice to have create `npm-shrinkwrap`s on publish, but those aren't supported by `greenkeeper` yet, only `greenkeeper-lockfile`.

This should hopefully speed up builds on Travis since it'll just `npm ci`, but we'll see how that goes.
@ghost ghost removed the backlog Issues not queued for work any time soon label Oct 30, 2018
randytarampi added a commit that referenced this issue Oct 30, 2018
@randytarampi
chore(letter): Might as well publish this so we can generate lockfiles.
4284750 
Per #175.
randytarampi added a commit that referenced this issue Oct 30, 2018
@randytarampi
WIP.
c294d8a 
Per #175.

It'd be really nice to switch from hoisted dependencies to relative local ones, except for all the package publishing breakage around `assets` and `css` and `views`. That is a really nice build time speed up though...
randytarampi added a commit that referenced this issue Nov 3, 2018
@randytarampi
chore(package): Add a top level package-lock.json, per #175.
7190500 
Might as well.
randytarampi added a commit that referenced this issue Mar 15, 2019
@randytarampi
chore(greenkeeper): [email protected]. (#175)
ccd26bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@randytarampi