Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support A4 Résumés #18

Closed
randytarampi opened this issue Aug 3, 2018 · 1 comment
Closed

Properly support A4 Résumés #18

randytarampi opened this issue Aug 3, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@randytarampi
Copy link
Owner

Related to #6 & #7, but I'd like to get this one done earlier than those two.

There's something going on with how puppeteer scales the page down for printing that forces it to go down to a small breakpoint for A4.

I can either change the small breakpoint itself or figure out how to force puppeteer to use a different pixels-per-inch value in its scaling calculation.

Or something.

@randytarampi randytarampi self-assigned this Aug 3, 2018
@randytarampi randytarampi added bug Something isn't working in progress Issues with solutions in progress labels Aug 3, 2018
randytarampi added a commit that referenced this issue Aug 3, 2018
@ghost ghost removed the in progress Issues with solutions in progress label Aug 3, 2018
@randytarampi
Copy link
Owner Author

I probably should've noted that the pixels-per-inch value here was 72, so US Letter (8.5" x 11") would be just over the small-screen breakpoint at 612px, while A4 (8.27" x 11.7") would be just below it at 595px, hence the 6px bump in 5141d96.

@randytarampi randytarampi changed the title Properly support A4 Resumés Properly support A4 Résumés Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant