Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling in one direction causing build up in lng variables #238

Open
wrenchInTheWorks opened this issue Nov 29, 2024 · 4 comments
Open
Assignees

Comments

@wrenchInTheWorks
Copy link

When scrolling even on the example the lng builds up when you warp around the world.
Screenshot 2024-11-29 at 8 48 34 PM

This is my first time posting an issue anywhere please let me know if I need include any other information.

@randyzwitch
Copy link
Owner

Hi @wrenchInTheWorks -

When you say "build up", you're talking about the values being outside of the -180, 180 bounds?

@randyzwitch
Copy link
Owner

It appears this is the default behavior in leaflet (the library that Folium wraps, that we wrap for this package 😅):

https://stackoverflow.com/questions/18063278/leaflet-getbounds-returning-longitudes-greater-than-180

@blackary, I'm not sure I even understand why you'd not want to wrap the values. Do you think we should add a keyword argument to st_folium?

@Michael-3Scape
Copy link

Hi Randy, Apologies for not getting back to you.

Yes, I was informed by my flatmate who is a geographer this is quite common for maps to do, my apologies for creating a fuss.

@blackary, I'm not sure I even understand why you'd not want to wrap the values. Do you think we should add a keyword argument to st_folium?

I'm passing values from a drawn box on the map to open topography which needs wrapped coordinates to download DEMs.

I will wrap the values in my code.

Cheers,
Michael

@randyzwitch
Copy link
Owner

No bother at all, it's definitely a weird default!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants