Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about the editor path #841

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

apcamargo
Copy link
Contributor

This PR addresses the discussion in #832 by improving the documentation for the editor setting. It now mentions that the full path to the editor binary may be required in certain cases. Since I am unfamiliar with how Rio resolves binaries on Windows, the documentation changes are currently focused on Unix-like systems. Please feel free to expand or adjust it as needed!

As a side note, I think it's a good idea to keep that issue open if there are plans to revisit this behavior in the future. Many users likely expect that whatever is in their PATH should work seamlessly (at least, that’s my perspective).

Copy link
Owner

@raphamorim raphamorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good thank you

@raphamorim raphamorim merged commit 034f9da into raphamorim:main Dec 8, 2024
6 checks passed
@raphamorim
Copy link
Owner

As a side note, I think it's a good idea to keep that issue open if there are plans to revisit this behavior in the future. Many users likely expect that whatever is in their PATH should work seamlessly (at least, that’s my perspective).

Let's see if it happens again after your change on docs, if does then I will do a better Rio warning on the terminal and include a message like "you filled with nu but maybe you mean path/to/nu"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants