Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build requirements issue: PEP517 build from sdist fails #396

Closed
radoering opened this issue Jul 29, 2024 · 1 comment
Closed

Build requirements issue: PEP517 build from sdist fails #396

radoering opened this issue Jul 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@radoering
Copy link

rapidfuzz defines the following build-requires:

"setuptools>=42",
"scikit-build~=0.17.0",

However, it looks like scikit-build 0.17.* is not compatible with the latest setuptools so that a pep517 build of rapidfuzz fails with

  File "/tmp/pip-install-ow77o4fv/rapidfuzz_312413af3a934e5aa35448753ccd577e/_custom_build/backend.py", line 9, in <module>
    from skbuild.cmaker import get_cmake_version as _get_cmake_version
  File "/tmp/pip-build-env-q86uqxab/overlay/lib/python3.10/site-packages/skbuild/__init__.py", line 10, in <module>
    from .setuptools_wrap import setup
  File "/tmp/pip-build-env-q86uqxab/overlay/lib/python3.10/site-packages/skbuild/setuptools_wrap.py", line 31, in <module>
    from .command import (
  File "/tmp/pip-build-env-q86uqxab/overlay/lib/python3.10/site-packages/skbuild/command/test.py", line 5, in <module>
    from setuptools.command.test import test as _test
ModuleNotFoundError: No module named 'setuptools.command.test'

The skbuild/command/test.py was removed in scikit-build 0.18 and setuptools.command.test was removed in setuptools 72. I think there are two options:

  • allow scikit-build 0.18
  • require setuptools<72

PS: We noticed this issue in the FreeBSD tests of Poetry, e.g. python-poetry/poetry#9427

@maxbachmann maxbachmann added the bug Something isn't working label Jul 29, 2024
@maxbachmann
Copy link
Member

I published a new version using scikit-build 0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants