Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enabling overlinking checks for conda builds in RAPIDS #21

Closed
vyasr opened this issue Feb 13, 2024 · 3 comments
Closed

Consider enabling overlinking checks for conda builds in RAPIDS #21

vyasr opened this issue Feb 13, 2024 · 3 comments
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 13, 2024

Enabling overlinking checks will help us capture issues with things like rpaths or libraries that we're implicitly/unexpectedly linking to.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 12, 2025

Based on my reading of https://rattler.build/latest/build_options/#dynamic-linking-configuration, rattler-build has overlinking checks on by default. Therefore, I think that this will be automatically resolved once #47 is complete. Please correct me if I'm misunderstanding though. @gforsyth it would help if for packages other than rmm (i.e. libraries that are no header-only) we could double-check the rattler logs and see that we are indeed passing overlinking/overdepending checks.

@gforsyth
Copy link

Yep, I can confirm that the overlinking and overdepending checks are on by default. There was some chatter on the prefix.dev discord channel about them not being quite "perfect" but that was also 8 or 9 months ago.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 12, 2025

Awesome. I'm going to close this as covered by #47, then.

@vyasr vyasr closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants