Forward-merge branch-24.02 to branch-24.04 #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds 23 benchmarks for BFS, connected components, triangles, and other related algos * Adds a shell script to run the algo benchmarks individually for easier comparison to NX * Fixes a bug in `nx_cugraph.generic_bfs_edges()` uncovered by these benchmarks Authors: - Rick Ratzel (https://github.com/rlratzel) - Erik Welch (https://github.com/eriknw) - Brad Rees (https://github.com/BradReesWork) Approvers: - Erik Welch (https://github.com/eriknw) URL: #4112
Heh, there is probably a "better" way to do this, but this way was fast and easy enough to do, and I hope is "good enough". Authors: - Erik Welch (https://github.com/eriknw) - Brad Rees (https://github.com/BradReesWork) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Ray Douglass (https://github.com/raydouglass) URL: #4108
Our current python API leverages dask to implement the `drop-duplicate` functionality but it carries a lot of overhead as it draws a significant amount of host memory and results into a crash when processing large graphs (4+ billion edges). This PR 1. Leverages the CAPI to internally drop multi edges when creating the PLC graph. 2. Deprecates the parameter `multi` which, when set to False, triggers the dask based `drop-duplicate` functionality 3. Add flag `do_expensive_check` to check for `NULL` values in the edgelist Authors: - Joseph Nke (https://github.com/jnke2016) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) URL: #4095
|
SUCCESS - forward-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-24.02that creates a PR to keepbranch-24.04up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.