Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concurrent_task_barrier() instead of synchronization #4

Open
seberg opened this issue Nov 4, 2024 · 0 comments
Open

Use concurrent_task_barrier() instead of synchronization #4

seberg opened this issue Nov 4, 2024 · 0 comments

Comments

@seberg
Copy link
Contributor

seberg commented Nov 4, 2024

Especially, the kmeans code has communication synchronization calls (but also knn, and others).

As @magnatelee mentioned, it should now be possible to replace these with TaskContext::concurrent_task_barrier() from legate (I am not sure if the handle.get_comms().barrier() would also do something, but I expect not).

This solution would be much preferred; on the implementation side, I do think it requires threading through the context (although, I am not sure the API needs anything from the TaskContext really).

@seberg seberg transferred this issue from another repository Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant