Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make conda installs in CI stricter #106

Merged
merged 3 commits into from
Oct 28, 2024
Merged

make conda installs in CI stricter #106

merged 3 commits into from
Oct 28, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#106

Proposes specifying the package version in conda install calls that install CI artifacts, to reduce the risk of CI jobs picking up artifacts from other releases.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 10, 2024
jameslamb
jameslamb commented Oct 10, 2024
View reviewed changes
ci/test_conda.sh
@@ -5,6 +5,8 @@ set -euo pipefail

. /opt/conda/etc/profile.d/conda.sh

VERSION="$(head -1 pynvjitlink/VERSION)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref:

pynvjitlink/conda/recipes/pynvjitlink/meta.yaml

Lines 4 to 7 in 14639d8

{% set version = load_file_regex(
load_file="pynvjitlink/VERSION",
regex_pattern="(?P<value>.*)"
)[0] %}

@jameslamb jameslamb mentioned this pull request Oct 10, 2024
Closed
@bdice bdice mentioned this pull request Oct 24, 2024
Merged
@jameslamb jameslamb changed the title WIP: make conda installs in CI stricter make conda installs in CI stricter Oct 28, 2024
@jameslamb
Copy link
Member Author

Looks like this is working with the fixes from #109 (thanks @bdice !). It's ready for review.

@jameslamb jameslamb requested a review from bdice October 28, 2024 14:48
@jameslamb jameslamb marked this pull request as ready for review October 28, 2024 14:48
@jameslamb jameslamb requested a review from a team as a code owner October 28, 2024 14:48
bdice
bdice approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameslamb. I think this is ready to merge.

@jameslamb
Copy link
Member Author

Great, thanks!

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 63536f4 into rapidsai:main Oct 28, 2024
39 checks passed
@jameslamb jameslamb deleted the ci-conda-installs branch October 28, 2024 19:44
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @jakirkham @bdice