Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUMMARY #5

Open
ad3429 opened this issue Nov 16, 2017 · 3 comments
Open

SUMMARY #5

ad3429 opened this issue Nov 16, 2017 · 3 comments

Comments

@ad3429
Copy link

ad3429 commented Nov 16, 2017

Summary Grade: Satisfactory

Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed excellent code practice, so make sure to keep that up!

I have made some comments in your code to take note of. First off, great job making use of id's and classes appropriately -- many learners seem to confuse this concept, so great job getting that right. One area of improvement is you should make sure to comment the main parts of your code in future projects. This greatly helps your development flow, especially as your projects get larger and more complex since they serve as a reminder to why you decided to code something a particular way. Here is a quick refresher on commenting in HTML and CSS, respectively:

html_comment

css comment

Great job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).

@ratinsl
Copy link
Owner

ratinsl commented Nov 16, 2017

Thank you very much ad3429 for the feedback. As far as commenting goes, can you provide an example of what kind of sections I should be commenting so I can follow the best practices?

I am new to GitHub, so I am not sure if you actually put comments in my code files. If so, could you please point me in the direction to take a look at that?

Thank You!
Ryan

@ad3429
Copy link
Author

ad3429 commented Nov 16, 2017

Something like this would suffice:

screen shot 2017-11-16 at 5 32 43 pm

@ratinsl
Copy link
Owner

ratinsl commented Nov 17, 2017

Thank you that helps a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants