Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find libmediainfo dynamic librairy on Windows and MacOS #180

Closed
getzze opened this issue Jul 15, 2024 · 2 comments · Fixed by #181
Closed

Cannot find libmediainfo dynamic librairy on Windows and MacOS #180

getzze opened this issue Jul 15, 2024 · 2 comments · Fixed by #181

Comments

@getzze
Copy link
Contributor

getzze commented Jul 15, 2024

pymediainfo wheels available on Pypi for Windows and MacOS come with a bundled libmediainfo file (not for Linux): https://pymediainfo.readthedocs.io/en/stable/
The file is in the package folder of pymediainfo. However it seems knowit is not looking in this location.

As a side-effect, it makes github tests fail on Windows and MacOS: Diaoul/subliminal#1154
@getzze getzze mentioned this issue Jul 16, 2024
Merged
@ratoaq2
Copy link
Owner

ratoaq2 commented Jul 16, 2024

Would you be able to create a PR with the fix for that?

If so, I could review it, merge it and create a new release

@getzze getzze mentioned this issue Jul 17, 2024
Merged
@getzze
Copy link
Contributor Author

getzze commented Jul 17, 2024

Done!
Also it would be great if you could merge #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search for mediainfo bundled library getzze/knowit
2 participants
@getzze @ratoaq2