Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding polling time from config #147

Open
BubuOT opened this issue Oct 24, 2022 · 6 comments
Open

Allow overriding polling time from config #147

BubuOT opened this issue Oct 24, 2022 · 6 comments
Labels
RFE request for enhancement

Comments

@BubuOT
Copy link

BubuOT commented Oct 24, 2022

It would be helpful to have development/staging targets poll hawkbit more often than the server-side defined polling interval (which is set to multiple hours so we save mobile bandwidth).

Our development targets are connected via an ethernet connection though and it would ease the testing workflow if we could tell those to just poll hawkbit every minute instead.

@BubuOT BubuOT changed the title Allow overriding pollking time from config Allow overriding polling time from config Oct 24, 2022
@ejoerns
Copy link
Member

ejoerns commented Oct 24, 2022

Since the config value provided by the DDI is only refered to as the 'suggested sleep time between polls' it also sounds reasonable to me to override this wish if we know better.

@ejoerns ejoerns added the RFE request for enhancement label Oct 24, 2022
@Bastian-Krause
Copy link
Member

If this is testing-specific, maybe this should be a command line option rather than a config option?

@BubuOT
Copy link
Author

BubuOT commented Oct 26, 2022

If this is testing-specific, maybe this should be a command line option rather than a config option?

That wouldn't work that well for us as the config file is device-specific (so can be different on test-devices) but the service invocation is defined in the firmware and identical on all our devices.

@Bastian-Krause
Copy link
Member

Hm, okay, I think we could also add that to the config.

I am not sure whether this should override the poll time announced by hawkBit or if we should use the lowest value?

@BubuOT
Copy link
Author

BubuOT commented Nov 3, 2022

I am not sure whether this should override the poll time announced by hawkBit or if we should use the lowest value?

Mh, good question. I think using the lowest value probably makes sense. (otherwise devices will be reported as "late" in hawkbit)

@Bastian-Krause
Copy link
Member

Makes sense. PR welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE request for enhancement
Projects
None yet
Development

No branches or pull requests

3 participants