Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typed pointer support? #333

Open
edg-l opened this issue Sep 29, 2023 · 2 comments
Open

Remove typed pointer support? #333

edg-l opened this issue Sep 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@edg-l
Copy link
Contributor

edg-l commented Sep 29, 2023

According to docs LLVM 17 removes typed pointers support completly and only supports opaque pointers.

On MLIR i think you can still make typed pointers but when lowered they become opaque.

https://llvm.org/docs/OpaquePointers.html#version-support

@raviqqe raviqqe added the bug Something isn't working label Sep 30, 2023
@raviqqe
Copy link
Owner

raviqqe commented Sep 30, 2023

Actually, I don't know LLVM kept the API which doesn't work anymore... They just missed it?

Edit: I keep the API for now until they remove it. Somehow, they kept the non-opaque pointer functionality within MLIR as of 17.0.0.

@Moxinilian
Copy link

For reference, MLIR kept the non-opaque pointer functionality so it is easier to transition out. Commit 4983432f17eb4b445e161c5f8278c6ea4d5d1241 has since removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants