Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS FT] GCS FT misconfiguration #2694

Open
1 of 2 tasks
kevin85421 opened this issue Dec 27, 2024 · 2 comments
Open
1 of 2 tasks

[GCS FT] GCS FT misconfiguration #2694

kevin85421 opened this issue Dec 27, 2024 · 2 comments
Assignees
Labels
1.3.0 bug Something isn't working gcs ft

Comments

@kevin85421
Copy link
Member

kevin85421 commented Dec 27, 2024

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

See this Slack thread for more details.

The user creates a RayService without setting the annotation ray.io/ft-enabled: "true", but they do set RAY_REDIS_ADDRESS and REDIS_PASSWORD. As a result, the RayCluster enables GCS FT and writes data to the external Redis, but KubeRay is unaware of this. KubeRay doesn't configure RAY_external_storage_namespace so that the RayCluster writes data to the key default in the Redis.

When the user triggers a zero-downtime upgrade, the new RayCluster also attempts to read metadata from the default key in Redis. Therefore, the new RayCluster will see some information from the old RayCluster.

Solution:

  • Explicitly disable GCS FT if KubeRay determines that the RayCluster has not enabled GCS FT.

Reproduction script

TODO

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added bug Something isn't working triage gcs ft and removed triage labels Dec 27, 2024
@kevin85421
Copy link
Member Author

/assign @rueian

@rueian
Copy link
Contributor

rueian commented Dec 28, 2024

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0 bug Something isn't working gcs ft
Projects
None yet
Development

No branches or pull requests

2 participants