-
Notifications
You must be signed in to change notification settings - Fork 540
[Feature] [kubectl-plugin] Expose setting shutdownAfterJobFinishes
and ttlSecondsAfterFinished
in ray job submit
#3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @ashrielbrian, thank you for your feedback. Would you mind sharing more details about how you use |
also cc @MortalHappiness @davidxia for input |
@CheyuWu are you interested in taking this issue if this request makes sense to Chi-Sheng and David? |
Hi @kevin85421 , sure, no problem |
Makes sense to me |
Let's wait for a response on this. As for me, I don't think we should support all the fields that a regular |
@MortalHappiness this feature requests make sense to me if the following two assumptions are correct:
@davidxia has relevant infra/platform team experience. Would you mind sharing your thoughts on these two assumptions? |
yes, in my team both the assumptions are the case for most users. Sometimes we make users use their own CR YAML when it's an infrequently requested config, but when we think many users might use them, we make them into CLI flags for our internal tools. |
@davidxia Thank you! @MortalHappiness does this make sense to you? |
Hi @kevin85421, Originally, our data scientists had to craft their own RayJob CR yaml files, but this very quickly became a painful UX for them, and we also wanted to remove the need to do An alternative we are considering is having our platform team manage a templated CRD, and our internal tool exposes CLI flags for specific parameters we'd like to expose, but this would do away with using the plugin as a wrapper. |
Thanks @ashrielbrian! This feature request makes sense to me. @CheyuWu you can start to work on it. |
Yes, this makes sense to me. |
Uh oh!
There was an error while loading. Please reload this page.
Search before asking
Description
Currently
shutdownAfterJobFinishes
andttlSecondsAfterFinished
aren't being exposed inkubectl ray job submit
, although they are available in the CRD. Ideally these two can be set as flags when using the plugin:Use case
I want ray jobs created by users to be automatically cleaned up, rather than be left around. This can be set if the user were to create and manage their own CRD yaml files, but not when using the plugin CLI.
In particular, after a ray job is submitted and completed, and another ray job with the same name is submitted, this returns an error since there's no cleanup of the previous RayJob CRD.
Related issues
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: