Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Inconsistent timestamp handling #48760

Open
rynewang opened this issue Nov 15, 2024 · 2 comments
Open

[core] Inconsistent timestamp handling #48760

rynewang opened this issue Nov 15, 2024 · 2 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P2 Important issue, but not time-critical

Comments

@rynewang
Copy link
Contributor

What happened + What you expected to happen

gcs::CreateErrorTableData takes a double timestamp.

Here it takes milliseconds from std clock:

gcs::CreateErrorTableData("task", error_message, current_time_ms(), job_id);

Here it takes nanoseconds from absl:

absl::GetCurrentTimeNanos(),

We need to:

  1. figure out it takes ms or ns
  2. fix by changing arg to absl::Time

Versions / Dependencies

master

Reproduction script

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@rynewang rynewang added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 15, 2024
@dentiny
Copy link
Contributor

dentiny commented Nov 15, 2024

Reading through the initial PR (https://github.com/ray-project/ray/pull/2256/files), the unit is actually seconds.

@dentiny
Copy link
Contributor

dentiny commented Nov 15, 2024

Then refactored to protobuf in #5024.

@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Nov 17, 2024
@jjyao jjyao added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

4 participants